Added border skin element#44
Open
thebluefish wants to merge 3 commits intofruxo:masterfrom
thebluefish:master
Open
Added border skin element#44thebluefish wants to merge 3 commits intofruxo:masterfrom thebluefish:master
thebluefish wants to merge 3 commits intofruxo:masterfrom
thebluefish:master
Conversation
Added border-width and border-color elements to the skin.
This reverts commit e2829c1.
Added border-width and border-color skin elements. The border behaves like expand, and thus can expand past the width of the element. The following elements: border-width 2 border-color #293956 Produces the drop-down menu border shown in: http://i.imgur.com/yGQxLAt.png
Contributor
|
👍, I have implemented this into https://github.com/NimbleTools/turbobadger as well. |
Owner
|
Status update: I have recently picked up some skin improvements i started working on ages ago. With those changes, skin bitmap doesn't have to point to a bitmap file on disk. It can point to shapes described as nodes in the skin file. Shapes can easily describe a border (with optional corner radius), or glyphs from icon fonts etc. |
Contributor
|
Oh, that sounds interesting. Looking forward to testing that out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added border-width and border-color skin elements. The border behaves
like expand, and thus can expand past the width of the element.
The following elements:
border-width 2
border-color #293956
Produces the drop-down menu border shown in:
http://i.imgur.com/yGQxLAt.png